Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top-level command aliases #439

Merged
merged 20 commits into from
Jan 31, 2019
Merged

Add top-level command aliases #439

merged 20 commits into from
Jan 31, 2019

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Jan 30, 2019 •
edited
Loading

E.g. neuro cp ... is the alias for neuro storage cp ...

@codecov
Copy link

codecov bot commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #439 into master will decrease coverage by 2.78%.
The diff coverage is 95.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage   92.62%   89.83%   -2.79%     
==========================================
  Files          31       34       +3     
  Lines        1925     2184     +259     
  Branches      205      250      +45     
==========================================
+ Hits         1783     1962     +179     
- Misses        120      177      +57     
- Partials       22       45      +23
Impacted Files Coverage Δ
python/neuromation/cli/share.py 82.6% <100%> (ø) ⬆️
python/neuromation/cli/image.py 93.33% <100%> (ø) ⬆️
python/neuromation/cli/config.py 80.95% <100%> (+0.46%) ⬆️
python/neuromation/cli/main.py 53.59% <100%> (ø)
python/neuromation/cli/model.py 88.13% <100%> (ø) ⬆️
python/neuromation/cli/storage.py 97.29% <100%> (ø) ⬆️
python/neuromation/cli/job.py 89.04% <100%> (+0.15%) ⬆️
python/neuromation/cli/completion.py 70% <60%> (+1.57%) ⬆️
python/neuromation/cli/utils.py 95.4% <94.2%> (+5.4%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3222a...da4ca08. Read the comment docs.

@shagren
Copy link
Contributor

shagren commented Jan 31, 2019

I like it!
btw there some old suggestions: #40

@atemate
Copy link
Contributor

atemate commented Jan 31, 2019

related issues that are to be updated after this PR: #248, #249, #125, #39

@asvetlov asvetlov merged commit 04a1b64 into master Jan 31, 2019
@asvetlov asvetlov deleted the top-level-commans branch January 31, 2019 18:33
@asvetlov asvetlov mentioned this pull request Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atemate atemate atemate left review comments

Assignees
No one assigned
Labels
CLIents platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asvetlov @shagren @atemate @astaff